Iterate through pages in VSAC API #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogversioning
force-pushed
the
mg/page_vsac
branch
from
8e13f91 to
ce37774
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mikix
approved these changes
Jul 31, 2024
cumulus_library/apis/umls.py
Outdated
Comment on lines
107
to
112
| # Do we need to fetch the next page? | ||
| # Note: the VSAC API hard codes the page size to 1000 | ||
| # and ignores the count param in the FHIR API | ||
| # (https://www.hl7.org/fhir/ValueSet-operation-expand.html), | ||
| # so we just hardcode an expansion of 1000 and hope it | ||
| # doesn't chage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the VSAC API support the pagination paramter for the expand operation.
Checklist
docs/) needs to be updated